[SOLVED] MP3-Releases: Marduk-Hearse-2003-DELTA

Summary:

Bad MP3 releases with only ID3v1 tags didn't get detected as MP3 files.

MP3-Releases: Marduk-Hearse-2003-DELTA

Nihil (guest) 07 Aug 2013 14:04

Hi guys,

I tried the new v0.6 with some mp3 releases, and here and there I got some issues with srs-creation.

My system:
OS: Win7 x64 ULTIMATE
pyRescene: v0.6 (commit: b95b489)

Issue:

Release: Marduk-Hearse-2003-DELTA
URL: srrdb. com/release/details/Marduk-Hearse-2003-DELTA
Bug-Info:
a) it shows for every mp3 the "pyrescene —help"-entry
b) it does NOT create srs-files for mp3

Input: D:\[..]\Marduk-Hearse-2003-DELTA>pyrescene . -d -l
Output:

+ show block

NOTE: install NumPy to speed up the reconstruction of RARs
      with a Recovery Record.
D:\Eigene Musik\Metal\Scene-Releases\2003\02\Marduk-Hearse-2003-DELTA
Usage: pyrescene.py  <sample file> [<full file>] [options]

To create a ReSample file (SRS), pass in the sample file.
This can be an AVI, MKV, MP4, WMV, MP3 or FLAC file.
    ex: srs sample.mkv -dd
To recreate a sample, pass in the SRS file and the full movie file
or the first file of a RAR set containing the full movie.
    ex: srs sample.srs full.mkv
    or: srs sample.srs full.rar

Options:
  --version             show program's version number and exit
  -h, --help            show this help message and exit
  -y, --always-yes      assume Y(es) for all prompts

  Creation options:
    -b, --big-file      Big file. Enables support for 'samples' over 2GB.
    -c FILE, --check=FILE
                        Check sample against given full MKV or AVI file to
                        make sure all tracks can be located before saving the
                        .srs file.

  Display options:
    -i, --info          Display sample info only. Does not create .srs file.
    -l, --srs-info      List SRS info only (use only with .srs input file).

  Output options:
    --d                 Use sample directory name as basis for generated .srs
                        file name.
    --dd                Use parent directory name as basis for generated .srs
                        file name.
    --ddd               Same as above, but puts the .srs file in the parent
                        directory.
    -o DIRECTORY, --output=DIRECTORY
                        Specify output file or directory path for .srs file.
                        If path is a directory, the --d and --dd flags will
                        work as normal.
    -m                  Ignore stored match offset against main movie file.
Usage: pyrescene.py  <sample file> [<full file>] [options]

To create a ReSample file (SRS), pass in the sample file.
This can be an AVI, MKV, MP4, WMV, MP3 or FLAC file.
    ex: srs sample.mkv -dd
To recreate a sample, pass in the SRS file and the full movie file
or the first file of a RAR set containing the full movie.
    ex: srs sample.srs full.mkv
    or: srs sample.srs full.rar

Options:
  --version             show program's version number and exit
  -h, --help            show this help message and exit
  -y, --always-yes      assume Y(es) for all prompts

  Creation options:
    -b, --big-file      Big file. Enables support for 'samples' over 2GB.
    -c FILE, --check=FILE
                        Check sample against given full MKV or AVI file to
                        make sure all tracks can be located before saving the
                        .srs file.

  Display options:
    -i, --info          Display sample info only. Does not create .srs file.
    -l, --srs-info      List SRS info only (use only with .srs input file).

  Output options:
    --d                 Use sample directory name as basis for generated .srs
                        file name.
    --dd                Use parent directory name as basis for generated .srs
                        file name.
    --ddd               Same as above, but puts the .srs file in the parent
                        directory.
    -o DIRECTORY, --output=DIRECTORY
                        Specify output file or directory path for .srs file.
                        If path is a directory, the --d and --dd flags will
                        work as normal.
    -m                  Ignore stored match offset against main movie file.
0:00:00.406000

Output (pyReScene_report_2013-08-07.txt):

INFO:D:\Eigene Musik\Metal\Scene-Releases\2003\02\Marduk-Hearse-2003-DELTA: Could not create SRS file for 01-marduk-hearse-delta.mp3.
INFO:D:\Eigene Musik\Metal\Scene-Releases\2003\02\Marduk-Hearse-2003-DELTA: Could not create SRS file for 02-marduk-phantasm_(possesed_cover)-delta.mp3.
INFO:D:\Eigene Musik\Metal\Scene-Releases\2003\02\Marduk-Hearse-2003-DELTA: Could not create SRS file for 01-marduk-hearse-delta.mp3.
INFO:D:\Eigene Musik\Metal\Scene-Releases\2003\02\Marduk-Hearse-2003-DELTA: Could not create SRS file for 02-marduk-phantasm_(possesed_cover)-delta.mp3.

Many thanks for help :).

Kind regards,
Nihil

Re: MP3-Releases: Marduk-Hearse-2003-DELTA

Gfy 02 Dec 2013 23:44

I've found a solution, but it isn't committed yet. You can see the result here:
http://www.srrdb.com/release/details/Marduk-Hearse-2003-DELTA

In resample/main.py, the following should be added to get_file_type function before the last return:

        # last attempt to detect an MP3 file by using the ID3v1 tag
        # (last 128 bytes of mp3 file)
        with open(ifile, 'rb') as ofile:
            ofile.seek(-128, os.SEEK_END)
            if ofile.read(3) == "TAG":
                return FileType.MP3

Yes, it was that easy to fix.